[lazarus] Lazarus broken

[Michal Bukovjan]

Hello,

just wanted to do something tonight, checked out latest Lazarus, and it
compiles, but if I run it the form goes away and hides.

It looks like someone broke the form's measurement code. Could someone look
into that and fix it (back)?

Upon quick inspection I found that CM_SHOWINGCHANGED was added and that some
portions code around these showing/hiding/resizing behavior was added. I
looked at the new code and the following came to my mind :

1. Why CM_SHOWINGCHANGED. It is totally useless, even in original Delphi (5)
VCL - I double-checked that, and it looks like a remnant from older version.
Just one more useless function in core class -> more bloat. Everything this
function does can be accomplished in UpdateShowing virtual method (and in
fact, is, just by performing this message).

2. This leads me to second question : Are we trying to copy the Borland VCL
(and pray Borland does not take any legal action) or just do a better, more
versatile, not Win32 centric, Borland compatible VCL? As I looked at the new
code, it is just a plain copy & paste from the Borland VCL. This applies to a
LOT of methods. In some, there is clearly no other way, but there is a lot of
code which could have been done differently and it was not, just copy and
paste.

3. If you make such changes that Lazarus won't run at least as it did (at the
first glance), please think twice about commiting them. It is very annoying to
fix things that already worked instead of working out unfinished parts of the
project.


Just some of my tonight's bitter thoughts.

Still, have fun

Michal Bukovjan


____________________________________________________________________
Get your own FREE, personal Netscape WebMail account today at http://webmail.netscape.com.