[Lazarus] About 0013268: SynEdit parses every line twice on load or paste (Attn: Flávio)

Flávio Etrusco flavio.etrusco at gmail.com
Wed Mar 4 22:00:29 CET 2009


On Wed, Mar 4, 2009 at 11:27 AM, Martin Friebe <lazarus at mfriebe.de> wrote:
> Hi,
>
> To take the discussion of the bug tracker.
>
> My current intention on this issue would be to solve the additional
> issues, such as double scan on Paste, or ensuring LoadFromFile only does
> a single scan for all lines in one go)
>
> This would mean the only Problem remaining is:
> If a user writes his own code, calling Lines.Add (or even Lines.Insert)
> in a loop. And does so without calling Lines.BeginUpdate before.
>
> While I admit that such a behaviour would add a lot of calculation
> overhead, with the current SynEdit implementation, I would also see it
> partly as a user error, since other Components also provide BeginUpdate
> or similar Methods.
> Still it should be fixed.
> But other changes could affect it (scan only on demand), and the amount
> of work, and the risk of breaking thinks are IMHO outweighing the
> current benefits.
>
> So once the above is closed, I would target that as "post 1.2" (simply
> meaning whenever some one has time to do it)
>
> Or do you think think this should be handled as a more severe issue?
>
> Best Regards
> Martin
>


Calling BeginUpdate is not enough, they must disable/unset the
highlighter to avoid the double parse.

Cheers,
Flávio




More information about the Lazarus mailing list