[Lazarus] IDEIntf: Extract PropHooks from PropEdits unit

Alexander Klenin klenin at gmail.com
Fri Jan 22 14:12:20 CET 2010


2010/1/22 Mattias Gärtner <nc-gaertnma at netcologne.de>:
> Zitat von Alexander Klenin <klenin at gmail.com>:
>
>> I continue refactoring of PropEdits unit.
>> I am ready to extract TPropertyEditHook into a separate unit.
>> Although Paul have given me commit access to IDEIntf,
>> he requested that I ask before committing serious changes.
>> So, is it ok to commit this refactoring?
>
> No, it breaks compatibility.

What compatibility?
I have successfully re-built lazarus after the refactoring -- no files except
propedits.pp required any changes.

> Why do you want to move it to another unit?

Because propedits.pp is a 6000+ line monster which is
very hard to comprehend, fix and improve.
Reducing the size by 1200 lines will alleviate the problem somewhat.
Also, many units that currently import propedits are actually only
using TPropertyEditHook, so after the extraction those units
can import much lighter propedithook unit instead.
Note that the patch I have currently prepared does not
implement the latter change yet, but it will follow shortly.

-- 
Alexander S. Klenin




More information about the Lazarus mailing list