[Lazarus] Package dialog ?

[Juha Manninen]

On Tue, Mar 24, 2015 at 1:45 PM, Michael Van Canneyt
<michael at freepascal.org> wrote:
> Ehm, 'many other complaints' ? that is just your opinion :-)

I opened the report partly because of other complaints and questions.
It was not only my opinion.


>> What more, there was a filter which prevented adding some files, but
>> didn't give any feedback.
> Hm. Strange argument. If that is a problem, just give the ability to switch
> filters. Not a reason to completely change the way of working ?

No, the user selectable filter is another thing.
There are hard-coded rules that prevent some files being added because
they are not valid for the project/package.
For some reason the rules are not needed when files are added by d'n'd
or file open dlg.
The code is inconsistent, I was planning to consult Mattias later about it.
Now I see there is another inconsistency :
  http://bugs.freepascal.org/view.php?id=27720
The code needs refactoring so that logic for accepting / rejecting a
file is in one place.

Project and package have lots of common features and similar code. I
have already created a common base class and an interface for them. I
hope it can be extended to share code for these dialogs.


Your plan looks good. You are clever!

> 3. Duplicate the 'New item' functionality in context menu.
>    Context menu and button bar should be in sync, IMHO.

What should be in sync? The Enabled state maybe?

> 9. Rework dependencies management to something more sane. Multi-select etc.

It could use the "Open Loaded Package" dialog after some modifications.

> The "clean up dependencies" should IMHO be removed, but that is a separate
> topic entirely.

Why? It is a very useful feature.

Juha