[Lazarus] Redundant assigned(X) and (X is Txxx) in Laz. sources

Juha Manninen juha.manninen62 at gmail.com
Fri Jan 12 20:44:47 CET 2018


On Fri, Jan 12, 2018 at 8:38 PM, Vojtěch Čihák via Lazarus
<lazarus at lists.lazarus-ide.org> wrote:
> I wrote a small routine to search Lazarus sources and it found about 60
> places similar to this (taborderdlg.pas, line 398):
>
> if Assigned(LookupRoot) and (LookupRoot is TWinControl) then begin
>
> Should I make a patch for all occurences?

Yes, I think the patch would be applied.
IIRC "is" was not allowed with Nil references in old FPC versions but
it was a long time ago.

BTW, a regular expression search in the Find in Files dialog would
have found those cases, too.

Juha


More information about the Lazarus mailing list