<div dir="ltr"><br><div class="gmail_quote">2011/3/31 Martin <span dir="ltr"><<a href="mailto:lazarus@mfriebe.de">lazarus@mfriebe.de</a>></span><br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div text="#000000" bgcolor="#ffffff"><div><div></div><div class="h5">
On 31/03/2011 00:31, Zaher Dirkey wrote:
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_quote">On Thu, Mar 31, 2011 at 12:21 AM,
Martin <span dir="ltr"><<a href="mailto:lazarus@mfriebe.de" target="_blank">lazarus@mfriebe.de</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div>On 30/03/2011 22:47, Zaher Dirkey wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
I found many of {$IFDEF SYN_LAZARUS} in SynEdit, my ask
is SynEdit used outside Lazarus (like Delphi for
example)?<br>
</blockquote>
</div>
they are a relict from another time....<br>
<br>
They were once meant to mark all places were SynEdit in
Lazarus changed from the original synedit.<br>
But they do no longer work.<br>
<br>
Only the SYN_LAZARUS version compiles, without it it will
not even compile.<br>
I started remove them a year or 2 back, but never
finished....<br>
<br>
Martin<br>
<font color="#888888">
<br>
</font></blockquote>
<div><br>
</div>
</div>
Can i remove it, and send the patch?<br>
<br>
</div>
</blockquote>
<br></div></div>
yes, but...<br>
do it in small bits, because I still need/want to review. And I am a
bit low on time...<br>
<br>
Also, if you do any other cleanup: do it in separate patches please<br>
<br>
Obviously the functionality need no review, just checking for
typos, or flipping the if and else part, etc (big operations like
this, almost always introduce an error somewhere)<br>
otherwise I had them all removed already<br>
<br>
Also I want to check any bigger block (several lines / if still
existing), if the code still serves as inspirations. But small
bits, are fine.<br>
<br>
If you want to clean up a particular bit, in order to start reading
into the code, thats cool...<br>
<br>
---<br>
Actually, just thinking about, could be easiest to run a perl script
over it.....<br>
<br>
Martin<br>
<br>
</div>
<br>--<br>
_______________________________________________<br>
Lazarus mailing list<br>
<a href="mailto:Lazarus@lists.lazarus.freepascal.org">Lazarus@lists.lazarus.freepascal.org</a><br>
<a href="http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus" target="_blank">http://lists.lazarus.freepascal.org/mailman/listinfo/lazarus</a><br>
<br></blockquote></div><br><br>Hi, i started to cleanup<br><br><a href="http://bugs.freepascal.org/view.php?id=19215">http://bugs.freepascal.org/view.php?id=19215</a><br><br>Please check this lines in SynTextDrawer<br>
<br>
procedure TheFontStock.SetStyle(Value: TFontStyles);<br>
<br>
// ASSERT(idx <= High(TheStockFontPatterns)); //Check this line <br><br clear="all"><br>SY<br>Zaher Dirkey<br>
</div>