<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 15.01.2016 23:30, Howard wrote:<br>
</div>
<blockquote cite="mid:56997323.3040906@talktalk.net" type="cite">
<blockquote type="cite" style="color: #000000;">Sorry, my
apologies - I missed that you didn't try it.
<br>
<br>
</blockquote>
Yes working fine for me (Windows 7 32bit and Linux 64 bit).
<br>
I'm relieved that such a simple change has had such a good effect,
and that no further tinkering with TShadowMenu size and
positioning code was required; and that my poorly implemented
scrolling code can therefore be dumped entirely.
<br>
</blockquote>
<br>
Yes, you must have wasted a lot of time on the extra scrolling code
:(<br>
+ Could you take a look also at this one?:
<a class="moz-txt-link-freetext" href="http://mantis.freepascal.org/view.php?id=29399">http://mantis.freepascal.org/view.php?id=29399</a><br>
Basically you should use a simple parented TEdit and not a modal
dialog. Take a look at grids in-place editor.<br>
<br>
To me it seems that you have taken hard and complicated routes at a
lot of places in the new menu editor, which are very bug-prone, hard
to maintain and hard to understand - instead of using easy and
simple ways. As a result, you wasted your time and also mine and
others that tried to understand what's going wrong in the
unnecessary code and tried to fix it.<br>
<br>
This is also the case of resource strings. Take a look e.g. at
r51249 and r51305. Why was the dialog so complicated with duplicate
strings? Yes and No as answers are clear enough.<br>
It stated:<br>
"Deleting this item will delete all subitems too.<br>
Delete this item and its subitems?"<br>
You use the word delete three times, (sub)items 2+2 times. Why? (And
I don't count the dialog title and former buttons.)<br>
Why not only the second line?: "Delete this item and its subitems?"
-> again it is clear enough. Furthermore, using the same words
and phrases over and over again is stylistically wrong.<br>
<br>
Honestly, the new menu editor is a translator's nightmare. Although
I do like what the new designer does, I don't really like how it is
written :( I tried to fix some code but I am somehow already tired
to go through all the issues.<br>
<br>
Please don't get me wrong - I don't want to offend you in any way. I
just want to explain that you should use the KISS-principle
whereever possible. It will not only save everybody's time but also
lead to better code. (I know, I also have hard time to apply KISS.)<br>
<br>
Ondrej<br>
<br>
PS: Just for comparison:<br>
BEFORE:<br>
<img src="cid:part1.07060500.03070302@kluug.net" alt=""><br>
<br>
AFTER:<br>
<img src="cid:part2.01030106.01090001@kluug.net" alt=""><br>
<br>
Even as a user, I need much more time to understand what's going on
in the first dialog...<br>
</body>
</html>