<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2017-12-12 21:36 GMT+03:00 Werner Pamler via Lazarus <span dir="ltr"><<a href="mailto:lazarus@lists.lazarus-ide.org" target="_blank">lazarus@lists.lazarus-ide.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<div bgcolor="#FFFFFF"><span class="gmail-">
<div class="gmail-m_1323075048826505142moz-cite-prefix">Am 12.12.2017 um 18:24 schrieb Sergey
Bodrov via Lazarus:<br>
</div>
<blockquote type="cite">
<div dir="auto"><div dir="auto">Strange way to make changes, but I don't mind.</div></div></blockquote></span>
What is strange?</div></blockquote><div><a href="http://wiki.freepascal.org/Creating_A_Patch">http://wiki.freepascal.org/Creating_A_Patch</a> describes two ways - make a small patch or send whole files with instructions, where they should be placed. So, I choose second way as more effective for massive changes. What's wrong?<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF">
Why I disassemble your changes? In this case, you still would not
have understood what this entire discussion is all about. Your
sources will be rejected because the essential code is buried
underneath tons of formatting changes. The developer who will review
such a bug report will not simply take your sources and copy them
over the official ones. He must understand what you changed, he must
be able to study your sources for possible side-effects which the
reporter often does not think of. With your code this is not
possible. I think on the other hand, that it would be a pity if your
work would not be considered. Therefore I joined this discussion.
Now that I understood one of the issues you are fixing and was able
to reproduce it I looked for differences between your code and the
"official" one, and found that it would be sufficient to replace
only a single procedure. With such a patch the reviewer knows what
is fixed and how it is fixed. And my report
(<a class="gmail-m_1323075048826505142moz-txt-link-freetext" href="https://bugs.freepascal.org/view.php?id=32814" target="_blank">https://bugs.freepascal.org/<wbr>view.php?id=32814</a>) gives him an easy
way to verify that a bug exists and that the patch really fixes it.<br></div></blockquote><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcolor="#FFFFFF"><br>
Or is it strange that I write the bug report for you? I just wanted
to help you. No problem if you write the next one yourself.<br></div></blockquote><div><br></div><div>I personally greteful, that you helps me. But I don't understand whole situation with code formatting, it looks like a some 'social bug' for me. If code formatting of existing code is prohibited, then must be some public warning in wiki.</div><div><br></div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"></blockquote><div>-- <br></div></div><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div><strong>Bodrov Sergey</strong><br></div><div>software development, IT consulting</div><div><a href="http://www.serbod.com" target="_blank">http://www.serbod.com</a></div><div><div><u>Phone (Belarus):</u> +375(25)794-21-58</div><div><u style="font-size:12.8px">Skype:</u><span style="font-size:12.8px"> sergey.bodrov1</span><br></div></div><div><u>e-mail:</u> <a href="mailto:serbod@gmail.com" target="_blank">serbod@gmail.com</a>, <a href="mailto:oxotnuk@yandex.ru" target="_blank">oxotnuk@yandex.ru</a></div><div><br></div></div></div></div></div></div>
</div></div>