<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2017-12-13 12:09 GMT+03:00 Werner Pamler via Lazarus <span dir="ltr"><<a href="mailto:lazarus@lists.lazarus-ide.org" target="_blank">lazarus@lists.lazarus-ide.org</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">Am 13.12.2017 um 08:35 schrieb Sergey Bodrov via Lazarus:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
I personally greteful, that you helps me. But I don't understand whole situation with code formatting, it looks like a some 'social bug' for me. If code formatting of existing code is prohibited, then must be some public warning in wiki.<br>
</blockquote>
<br></span>
Looks like you really don't understand. I won't repeat what has been said before. Just one question: If you were the reviewer who added this patch to fcl and suddenly somebody finds out that this patch creates a crash somewhere else, how can you find the faulty line if there are thousands of irrelevant changes but 1 tiny incorrect "shr 1" somewhere?<br></blockquote><div><br></div><div>I can't make review from single line of code or single function, that I don't know, how it works and how connected to another parts. If it obvious error, like missed inherited destructor, or known point of exception - then it easy. But when it some hidden bug, wrong behavior - then need some code preparing, that make wrong parts of code obvious or force some visible effect in runtime. Comments, naming, debug output, assertions. And only when code is perfectly looks and works, then it can be cleaned from redundant parts and treated as some blackbox.</div><div><br></div><div>I thinked, that sources of FPC compiler and RTL is that 'holy bible', where every line is critical and must be carefully checked. But CHM package is optional and not documented, it have many unused and debug lines. I even don't sure, that it actually part of FCL.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
If you really want code to be reformatted you must provide a separate patch which does not change anything in the logics of the code.</blockquote><div><br></div><div>It make a sense. But how to bring a patch with only code formatting? It must be single huge diff, or splitted for different blocks? And why file with massive changes can't be treated as new file?</div><div> </div></div><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div><strong>Bodrov Sergey</strong><br></div><div>software development, IT consulting</div><div><a href="http://www.serbod.com" target="_blank">http://www.serbod.com</a></div><div><div><u>Phone (Belarus):</u> +375(25)794-21-58</div><div><u style="font-size:12.8px">Skype:</u><span style="font-size:12.8px"> sergey.bodrov1</span><br></div></div><div><u>e-mail:</u> <a href="mailto:serbod@gmail.com" target="_blank">serbod@gmail.com</a>, <a href="mailto:oxotnuk@yandex.ru" target="_blank">oxotnuk@yandex.ru</a></div><div><br></div></div></div></div></div></div>
</div></div>