[lazarus] FindInFiles.diff

[Mattias Gaertner]

On Sun, 3 Aug 2003 23:27:20 +0200
Vincent Snijders <vslist at zonnet.nl> wrote:

> On Sun, 03 Aug 2003 14:47:00 -0400
> Bob Wingard <bwingard at gt.rr.com> wrote:
> 
> > Extends InputHistory class to include Find In Files Dialog Search
> > Paths and Masks
> > Modify UnitEditor To load and save Find In Files Dialog History.
> > 
> > Bob
> I am very fond of the findinfiles dialog (and heaptrc). Some more
> remarks, hopefully helpful.
> 
> The msgview form doesn't free the DirectoryList. Attached patch solves
> thie memoryleak.

Thanks. Applied both fixes.

 
> I think that the FindClose should be outside the if then block in de
> FindMatchingFiles procedure in ideproc. What happens if FindFirst return
> 0, for example when there are no *.inc files in a directory. FindClose
> is not called. This is also true for the recursive find, but there
> FindFirst (almost?) never return zero, for a directory contains
> the . file. Notice that the check if a file is a directory
>       if ((faDirectory and FileInfo.Attr)>0) then (line 2104)
> is only done for the first file found. Maybe this should be put inside
> the repeat until loop.

Yep.


Mattias