[lazarus] findinfilesdlg.pas, uniteditor.pp patches

[Mattias Gaertner]

On Mon, 04 Aug 2003 19:26:35 -0400
Bob Wingard <bwingard at gt.rr.com> wrote:

> findinfilesdlg.pas - add Options as a set of  TLazFindInFileSearchOption 
> with a couple of functions and procedures for getting and setting these 
> options.
> 
> uniteditor.pp - used new options in the code that calls the search 
> functions.

Applied.


 
> Mattias,
>     What I would like to do now is take a look the MessageView dialog. I 
> think it should have a TNoteBook so that the user does not loose his (or 
> her) messages when a search is done. My thought is that we can add a new 
> tab to the form each time a search is completed, the TNoteBook pages 
> would show a close buttons and if the user clickes on the close button 
> the notebook would close as long as it was not the first Tab, the first 
> tab would just hide the form. The first Tab would be where compiler and 
> syntax messages would be reported.
> maybe somthing like:
> 
> function MessageView.AddSearchTab('Tab Title'): TListBox;  //Some day 
> maybe TSynEdit

Or maybe a special component, containing a synedit for the results, a
synedit for the context and some buttons. 


> By returning the ListBox we could do an Assign instead of looping 
> through and adding each string, should be faster.

Right.
It would be nice, to add results already during search. A find in files can
take time and we should provide a Abort button.

 
> Then we could assign a different procedure to the Selection Change event 
> or Double Click Event Than the current do jump to compiler message 
> procedure.
> 
> Let me know what you think.

As stated some time ago, I think, we should create a separate window for the
search results. Together with a plugin system. But this is my personal wish,
and I'm too busy at the moment to do it, so please add the above features to
the message view. When I have some time next week I will start the search
window. It should not be hard to migrate your code.
BTW, I would like to see all place in a file, not only the first. Maybe we
should add an option to the dialog. What do you think?


Mattias