[lazarus] Search results windows patch
bwingard at gt.rr.com
Sat Nov 8 19:28:47 EST 2003
On Sat, 2003-11-08 at 18:12, Mattias Gaertner wrote:
> On Sat, 08 Nov 2003 15:37:01 -0600
> Bob Wingard <bwingard at gt.rr.com> wrote:
> > Patch to move the search functions for find in files to a dialog box
> > with a cancel button. The search now returns all matches within a file.
> Applied. Thanks.
> > Be careful the TStrings implementation used by the listbox control gets
> > really slow when there are more than a couple thousand matches. I tried
> > it with the TSynMemo and the TStrings implementation is much faster when
> > it has a large number of strings. I did a regex search for ^procedure
> > and the Tsynmemo handled the 13k matches without a problem. Do not try
> > this with the Tlistbox Tstrings.
> TListBox is not very optimized. OTOH: What kind of user can handle 13k of
> listbox items?
Not saying its a good idea for so general a search, just a warning
that you will not be happy sitting and waiting on the list box to re
paint or whatever its doing.
> > Bob
> > On Fri, 2003-11-07 at 22:43, Jason King wrote:
> > > (and its probably got my earlier patch in it too , sorry about that)
> > >
> > > this implements the search results window. If you do "Find in Files" ,
> > > "search all open files" you will get a list of search results for your
> > > text. It only lists the first result in each file , not all of them so
> > > far. clicking on the entry in the search result window jumps to that
> > > line in the file.
> > >
> > > no doubt needs more work to make it less annoying , but its a start I
> > > guess. Still need to do notebook for several results , and search again
> > > button.
> > >
> > > searchresultview.pp is a blatent copy of messageview.pp
More information about the Lazarus