[Lazarus] TAChart: Request to review/apply patch 12758

[Luiz Americo Pereira Camara]

Florian Klaempfl escreveu:
> Alexander Klenin schrieb:
>   
>> On Thu, Dec 11, 2008 at 20:16, Florian Klaempfl <florian at freepascal.org> wrote:
>>     
>>> Alexander Klenin schrieb:
>>>       
>>>> I.e. my specific problem can be solved in SVN by creating a branch of TAChart
>>>> component and giving me commit access to it, but then
>>>> similar branch should be created for my patches to DBGrid,
>>>> and yet another one for patches to SynEdit (both stalled for about a month now),
>>>> etc.
>>>> Obviously, this is not a scalable solution for many developers ;-)
>>>>
>>>>         
>>> But isn't the problem that the patches don't get into the central
>>> repository?
>>>       
>> They will get there eventually. The key thing is that patches can be 'batched'
>> for review/application and not spoon-fed one by one.
>>     
>
> This can be done with an svn branch as well? I'am rather sure the
> lazarus people give you write access to a branch if you ask. 

Yes. But other developers (like me) may want their branches that will 
require some admin effort (create branch, give access rights) from the 
main developers tree. With DVCS you start your own branch without  
incommode nobody.

An real example:
- i'm the developer of  the Sqlite component shipped with fpc.
- Previously i worked locally and send various fixes as a patch to the 
fpc team. They complained.
- Then i started to send each change separately. So i was developing a 
change and then sending a patch separately. But i have other things to 
improve/fix and i had to wait to apply before i start another feature or 
fix.
- my solution: i created a mirror in my svn repository ( 
http://code.google.com/p/luipack/source/browse/#svn/trunk/sqlite/dataset 
) and i commit each change to my svn separately and then send the 
changes in order. The ugly part is that there's no way to create the 
patches directly
 from my svn i have to copy the files of a revision (if fpc is sync with 
rev 5, i copy rev 6) from my repository to the fpc repository then 
create a patch and sent. Them i wait to apply. Them i can do the same 
for rev 7. Very ugly.


> And this
> has a real advantage: if you just commit your changes to your local
> repository, the changes get lost if you "disappear"  and nobody did pull
> them yet (this is also why we recommend to attach patches to "bug
> reports", they won't get lost this way), the patches are lost. If they
> are in a svn branch, they aren't lost.
>   

You can publish your branch in the net. There are several free services 
that do that.

Remember that are other DVCS than git. (git is bad because of your 
complex installation at windows)

Luiz