[Lazarus] Proper implementation of TDataLink descendant

Luiz Americo Pereira Camara luizmed at oi.com.br
Fri Aug 5 06:43:34 CEST 2011


On 5/8/2011 01:34, Alexander Klenin wrote:
> On Fri, Aug 5, 2011 at 15:11, Luiz Americo Pereira Camara
> <luizmed at oi.com.br>  wrote:
>> I implemented BlockReadSize
>>
>> See http://bugs.freepascal.org/view.php?id=19897
>>
>> The patch is minimal and do what you (and I) need without much complexity
>>
>> In fact it took more time to do the Delphi testing and to compile fpc trunk
>> than the time to code the patch itself
> Thank you. I know the required part of functionality is very simple.
> Unfortunately, I have a history of rejected FPC patch because
> I implemented only the part I needed, not the whole spec.

I tested the Delphi behavior before so AFAIK is complete.
> This is why I asked first instead of programming it myself.
> Anyway, I hope you are luckier than me, and your patch will be applied ;-)
>
> The patch seems to have problems with the whitespace --
> there are spaces at the ends of added lines and tabs instead of spaces
> are used for indentation sometimes.
> Other than that, it looks fine, thanks again.

I fixed that

Luiz





More information about the Lazarus mailing list