[Lazarus] Can someone with commit privileges submit this fix?

[Marc Weustink]

zeljko wrote:
> On Thursday 24 of February 2011 06:25:08 John Stoneham wrote:
>
>> procedure TOICustomPropertyGrid.ValueComboBoxMouseUp(Sender: TObject;
>>    Button: TMouseButton; Shift: TShiftState; X, Y: Integer);
>> begin
>>    if (Button=mbLeft) then begin
>>      if (Shift=[ssCtrl,ssLeft]) then
>>        DoCallEdit(oiqeShowValue)
>>      {$IFNDEF LCLCarbon}
>>      else if (FFirstClickTime<>0) and (Now-FFirstClickTime<(1/86400*0.4))
>> then
>>        ValueEditDblClick(Sender);
>>      {$ENDIF}
>>    end;
>> end;
>
> No, there shouldn't be any LCLXXX ifdef inside LCL or IDE , there must be
> other way to fix this.

The question is, why is this code there in the first place. It looks 
like a LCL workaround for a missing dblckick event.

IMO, the ifndeffed code should be removed and it should be handled in 
the dblclick event handler. The broken platforms should be fixed.

Marc