[Lazarus] Problems creating Lazarus installer + readme/batch patch

[Reinier Olislagers]

On 1-8-2012 14:27, Martin wrote:
> On 01/08/2012 07:20, Reinier Olislagers wrote:
>> BTW, patch attached that:
>> - clarify/update readme (mentioned 2.2 fpc compiler instead of 2.6.0)
>> - lets you use environment variables for BUILDDIR
Thanks!

> I skipped the build dir part.
> 
> BUILDDIR is too generic as a name, and may be set by something else. If
> so, the script would delete whatever directory that points too.
> 
> Feel free to introduce
> 
> LAZTEMPBUILDDIR
> 
> But do not replace it everywere. Initialize BUILDDIR from the former.
> And maybe add a check, for empty, or none existent.
Thanks, make sense.
Done; check included, see patch.
Tested by setting LAZTEMPBUILDDIR and it does put the output there.

The patch also contains a fix for the iss file (a Pascal begin..end
block without colon after the end ;) - otherwise I get this error:

Error on line 383 in
C:\Development\lazarus\tools\install\win\lazarus.iss: Column 2:
Semicolon (';') expected.
Compile aborted.

If you want me to open mantis issues instead, I'd be happy to...

However, I now get this:
Error on line 417 in
C:\Development\lazarus\tools\install\win\lazarus.iss: Column 40:
Type mismatch.

The lines in question:
var
  FileName: string;
  Content: string;
begin
  FileName := ExpandConstant(CurrentFileName);
  LoadStringFromFile(FileName, Content); //<-- line 417; col 40 is the ;

Those lines appear to have been there since r6092 (svn blame)... perhaps
it's the fact I'm using Unicode Inno Setup or something I'm not seeing?
(No experience with PascalScript or those functions, nor do I know what
CurrentFileName is, so more or less blindly guessing)

I upgraded my Inno Setup to the latest, 5.5.1 unicode, no change.

Thanks,
Reinier

-------------- next part --------------
Index: tools/install/win/lazarus.iss
===================================================================
--- tools/install/win/lazarus.iss	(revision 38105)
+++ tools/install/win/lazarus.iss	(working copy)
@@ -378,7 +378,7 @@
       MsgBox(s, mbInformation, MB_OK );
       Result := false;
       exit;
-    end
+    end;
 
 	UpdateUninstallInfo;
     UnInstaller := RemoveQuotes(GetUninstallData('UninstallString'));
Index: tools/install/win/create_installer.bat
===================================================================
--- tools/install/win/create_installer.bat	(revision 38105)
+++ tools/install/win/create_installer.bat	(working copy)
@@ -10,7 +10,9 @@
 
 :: Path to build directory.
 :: In this directory an image of the installation will be built.
+:: If the user specified a LAZTEMPBUILDDIR environment variable, use that instead.
 SET BUILDDIR=c:\temp\lazbuild
+if NOT [%LAZTEMPBUILDDIR%]==[] SET BUILDDIR=%LAZTEMPBUILDDIR%
 
 :: Path to the svn executable
 if [%SVN%]==[] SET SVN="c:\program files\subversion\bin\svn.exe"