[Lazarus] ShellTreeView/ShellListView and Root

Felipe Monteiro de Carvalho felipemonteiro.carvalho at gmail.com
Mon Apr 8 09:18:45 CEST 2013


On Sun, Apr 7, 2013 at 1:02 PM, Bart <bartjunk64 at gmail.com> wrote:
> Committed in r40732.

I was planning on reviewing it today. I don't like this chunk:

@@ -631,7 +641,6 @@
 begin
   // avoids crashes in the IDE by not populating during design
   if (csDesigning in ComponentState) then Exit;
-
   r := GetLogicalDriveStrings(SizeOf(Drives), Drives);
   if r = 0 then Exit;
   if r > SizeOf(Drives) then Exit;


The empty line marks the region for which the comment is valid, it
should have been deleted.

Also:

+  if not FilenameIsAbsolute(Result) then
+    Result := GetRootPath() + Result;    // Include root directory

I think this is redundant, this entire part could be deleted I think.

-- 
Felipe Monteiro de Carvalho




More information about the Lazarus mailing list