[Lazarus] Why lazchmhelp.pas sets InheritHandle conditionally on fpc version?

[Mattias Gaertner]

On Tue, 02 Sep 2014 09:54:50 +0200
Luca Olivetti <luca at wetron.es> wrote:

> I saw in the 1.2.4 source this:
> 
> {$if FPC_FULLVERSION<20604}
> Proc.InheritHandles := false;
> {$endif}
> 
> 
> Why is it conditional?

It is not conditional in 1.3.

> Maybe I'm biased by my bad experience with it being true by default, but
> I think it should be always set to false (apart from the fact that it
> didn't work in fpc, and it has been fixed exactly in 2.6.4, making the
> above completely useless).
> 
> BTW, in my local copy I also modify lazhelphtml.pas
> 
> 
> --- lcl/lazhelphtml.pas (revisión: 45586)
> +++ lcl/lazhelphtml.pas (copia de trabajo)
> @@ -367,6 +367,7 @@
>    try
>      BrowserProcess:=TProcessUTF8.Create(nil);
>      try
> +      BrowserProcess.InheritHandles:=false;
>        BrowserProcess.CommandLine:=CommandLine;
>        BrowserProcess.Execute;
>      finally

1.3 has the above code.

Mattias