[Lazarus] CHM help package

Werner Pamler werner.pamler at freenet.de
Mon Dec 11 22:27:33 CET 2017


Am 11.12.2017 um 20:53 schrieb Marco van de Voort via Lazarus:
> On Mon, Dec 11, 2017 at 06:32:45PM +0100, Werner Pamler via Lazarus wrote:
>> I cloned your repo on my HD, and went through it step by step while
>> always trying to build lhelp, I could remove everything from the folder
>> chm except for these units: chmfifimain, chmreader, chmsitemap, chmtypes
>> (and chmobjinstance.inc).
> I walked through chmreader, and found one minor fix, a comparison of a filename
> parameter with an extension should be lowercase. Fixed in r37714

And chmfifimain seems to have a memory leak in "destructor 
TChmSearchWriter.Destroy;" which does not call "inherited" -- see 
attached patch.
-------------- next part --------------
Index: chm/src/chmfiftimain.pas
===================================================================
--- chm/src/chmfiftimain.pas	(revision 37715)
+++ chm/src/chmfiftimain.pas	(working copy)
@@ -392,6 +392,7 @@
 
 begin
  freeandnil(FActiveLeafNode);
+ inherited;
 end;
 
 


More information about the Lazarus mailing list