[Lazarus] [PATCH] Fix problems with writing ProductVersion in VersionInfo

Juha Manninen juha.manninen62 at gmail.com
Tue Oct 3 20:29:47 CEST 2017

On Tue, Oct 3, 2017 at 6:06 PM, Чернов Дмитрий via Lazarus
<lazarus at lists.lazarus-ide.org> wrote:
> Good day everyone.
> Recently I've recognized some problems with ProductVersion field in the
> integrated Lazarus support of VersionInfo. Version of Lazarus is 1.6.4.
> Attached patch fixes them. It's based on Lazarus codebase from the 1.6.4
> release.

Thanks. I applied it in r55968 with some editing.
It is recommended to create patches always from SVN trunk (development
version). Now the patch fortunately applied with offsets.
Also please create a patch from the source root directory.
[lazarus_trunk]$ cd ide
[ide]$ patch -p1 < ~/patch/Fix-problems-with-writing-ProductVersion.patch
patching file w32versioninfo.pas
Hunk #1 succeeded at 427 (offset 1 line).
Hunk #2 succeeded at 451 (offset 1 line).
Hunk #3 succeeded at 515 (offset 3 lines).

What do you think of this?
Patches are welcome also for it.

> And also, you're have an typo on this page:
> https://www.lazarus-ide.org/index.php?page=contact

Thanks. I fixed the typo in lazaruswebsite repo in r172.

The actual web page will be updated later together with 1.8 release
related changes.


More information about the Lazarus mailing list