[Lazarus] Lazarus Release Candidate 2 of 2.0

[Mattias Gaertner]

On Sat, 3 Nov 2018 13:37:20 +0000
C Western via Lazarus <lazarus at lists.lazarus-ide.org> wrote:

> On 01/11/2018 07:46, Mattias Gaertner via Lazarus wrote:
> > The Lazarus team is glad to announce the second release candidate of
> > Lazarus 2.0.
> >  
> I am still seeing the error on loading a (specific) package with
> missing dependencies, but I have been able to do some debugging to
> track down the error. It is clear I should have specified the
> platform in my original message, as I think the error will not
> manifest on windows. I think the error is in
> packager/packagesystem.pas:
> 
> 933    function TLazPackageGraph.OpenDependencyWithPackageLink(
> 
> 934      Dependency: TPkgDependency; PkgLink: TPackageLink;
> ShowAbort: boolean
> 
> 935      ): TModalResult;
> 942    begin
> 943      NewPackage:=nil;
> 944      XMLConfig:=nil;
> 945      BeginUpdate(false);
> 946      try
> 947        AFilename:=PkgLink.GetEffectiveFilename;
> 948        if pvPkgSearch in Verbosity then
> 949          debugln(['Info: (lazarus) Open dependency: trying 
> "'+Dependency.PackageName+'" in '+dbgs(PkgLink.Origin)+' links: 
> "'+PkgLink.GetEffectiveFilename+'" ...']);
> 950 //debugln(['TLazPackageGraph.OpenDependencyWithPackageLink 
> AFilename=',AFilename,' ',PkgLink.Origin=ploGlobal]);
> 951        if not FileExistsUTF8(AFilename) then begin
> 
> ***Issue is here: FileExistsUTF8() returns true for a directory on 
> Linux, (but false on windows) and the preceding GetEffectiveFilename 
> just returns a directory

Thanks for debugging!

I added a directoryexists check and fixed GetEffectiveFilename to not
expand an empty filename.

Mattias