[Lazarus] Merge request

[Pascal Riekenberg]

What about reopening the original issue and request a merge?

Pascal


> Martin Frb via lazarus <lazarus at lists.lazarus-ide.org> hat am 6. September 2019 um 12:24 geschrieben:
> 
> 
> On 06/09/2019 10:48, Mattias Gaertner via lazarus wrote:
> > On Fri, 6 Sep 2019 08:05:57 +0200 (CEST)
> > Pascal Riekenberg via lazarus <lazarus at lists.lazarus-ide.org> wrote:
> >
> >> Hello,
> >>
> >> i've added a merge request to the wiki
> >> https://wiki.freepascal.org/Lazarus_2.0_fixes_branch#Submitted_by_developer_.2F_committer_and_waiting_for_testing_.28do_not_commit_yet.29 .
> >> Is this a proper way to request merges?
> > Yes.
> >
> > Mattias
> Actually the "submitted by developer" section is meant to be used by 
> team members (usually, but not always the committer of the revision) only.
> That means the responsible member has signed the patch off.
> 
> 
> We used to have a "submitted by other" section.
> But putting something in there, did still mean you needed to catch the 
> developers (who committed) eye, and have him sign off on it. Otherwise 
> it would sit there forever.
> 
> I moved them accordingly. But that means that you will need to ask the 
> committer of that patch.
> -- 
> _______________________________________________
> lazarus mailing list
> lazarus at lists.lazarus-ide.org
> https://lists.lazarus-ide.org/listinfo/lazarus