[Lazarus] Merge request (Attn Juha)

[Juha Manninen]

On Fri, Sep 6, 2019 at 7:17 PM Martin Frb via lazarus
<lazarus at lists.lazarus-ide.org> wrote:
> Hi Juha,
> can you have a quick look if this commit of yours can be merged to 2.0 branch?
> r60719 IDE: Call DoCallBuildingFinishedHandler after ToolState is reset. Issue #0035240
>
> On 06/09/2019 12:33, Pascal Riekenberg via lazarus wrote:
>
> What about reopening the original issue and request a merge?
>
> Probably fine too.
>
> I would first put in here on the mail list. With a subject that catches the eye of the person responsible. That is often faster. I done that myself with fpc issues on the fpc list.
>
> ----------
> I  had not actually looked at the issues. One was a fix to my report. I remember having tested the result myself. So I moved that to "confirmed".
>
> The other issue still needs to be looked at. The issue was assigned to Juha, so lets ping him.
>
> As a general note, it is a fixes branch. The issue reads like a feature / extension of existing abilities.
> Then again that does not need to be 100% strict. I.e. being IDE core code (not affecting user apps) and having been in trunk for a while suggest a very low risk.

Yes, the "Call DoCallBuildingFinishedHandler after ToolState is reset"
issue was reopened and marked for merging.
It is a bug fix because the handler was clearly called in a wrong place.

Sorry for a 2 weeks delay in my reply. I didn't read this list for a
while. I hope I will have more time for Lazarus issues during the
coming winter.

Regards,
Juha