[Lazarus] JCF2 patch in trunk

Michael Van Canneyt michael at freepascal.org
Fri Sep 11 13:22:22 CEST 2020



On Fri, 11 Sep 2020, Mattias Gaertner via lazarus wrote:

> On Fri, 11 Sep 2020 13:14:59 +0300
> "Alexey Tor. via lazarus" <lazarus at lists.lazarus-ide.org> wrote:
>
>> https://github.com/graemeg/lazarus/commit/f4ffd5e0640948e9c396e1ef1b2aacd90512ac77
>>
>>     if StartsText('{$include',pcToken.SourceCode)=true then
>>        lPos:=10
>>      else if StartsStr('{$I',pcToken.SourceCode)=true then
>> 
>> 
>> a) $include is searched case-insens? why no space after "$include" to 
>> avoid incorrect include?
>> 
>> b) $I is searched case-insens? seems no! why no space after $I to
>> avoid other directive?
>
> Are these trick questions?
> Simply reading the code and using Find Declaration answers both
> questions in less time, than it takes to write this mail.

I think he tries to point out there is a discrepancy in case-sensitiveness
treatment, and that it is safer to add ' ' after the directive to prevent
false positives.

Michael.


More information about the lazarus mailing list