[lazarus] Patch for searchresults dialog
Bob Wingard
bwingard at gt.rr.com
Sat Nov 22 09:45:31 EST 2003
Mattias,
I found a small problem after I sent you the patch. Replace the
LazLBMousemove routine in SearchViewResult.pp with this to correct it.
Bob
{Keeps track of the Index of the Item the mouse is over, Sets ShowHint
to true
if the Item length is longer than the Listbox client width.}
procedure TSearchResultsView.LazLBMousemove(Sender: TObject; Shift:
TShiftState;
X, Y: Integer);
begin
if Sender is TLazSearchResultLB then
begin
with Sender as TLazSearchResultLB do
begin
fMouseOverIndex:= GetIndexAtY(Y);
if (fMouseOverIndex > -1) and (fMouseOverIndex < Items.Count) then
begin
if (Canvas.TextWidth(Items[fMouseOverIndex]) > Width) then
ShowHint:= True
else
ShowHint:= False;
end;//if
end;//with
end;//
end;//LazLBMousemove
On Fri, 2003-11-21 at 21:33, Bob Wingard wrote:
> Mattias,
> Pretty big patch here, for me anyway :)
>
> 1. Cleaned up the find in files routines in Uniteditor.pp
> 2. Implement Search Again button on SearchResultsView form.
> 3. Added Highlighting of the search phrase in the Results List box.
> 4. Added a tool tip to the list box to show the search result if the
> result is wider than the list box width.
>
> I have a couple of questions.
>
> It looks like the list box is not taking the vertical scroll bar width
> into account when deciding whether or not to show the horizontal scroll
> bar. Some times text is in the list that is just wider than the width of
> the client area in the list box but the scroll bar is not displayed. If
> you resize the list box smaller then the scroll bar will be visible. I
> looked through the code but could not determine where this is taking
> place, any help?
>
> I would get the list box to stop drawing twice when it's style is set to
> ownerdrawn, again not sure where to start.
>
> Vincent,
>
> Thanks for your help.
>
> I was not able to duplicate the Black on Black text that you saw in
> KDE yesterday. Look at it now, I explicitly set the canvas.color to
> clWhite. I think I remember seeing somewhere in the code that, but I
> cannot find it now, that some of the colors are loaded from user
> preference. Maybe if Gnome is not running this is where the problem
> happens. Mattias?
>
> Regards,
> Bob
>
> On Thu, 2003-11-20 at 19:27, Mattias Gaertner wrote:
> > On Thu, 20 Nov 2003 22:49:42 +0100 Vincent Snijders <vslist at zonnet.nl>
> > wrote:
> >
> > > Hi,
> > >
> > > Attached patch solves some issues with the find in files search results
> > > dialog.
> > >
> > > - Some memory leaks.
> > > - Clarified comment a bit.
> > > - Access Violation when clicking on a search result.
> >
> > Applied. Thanks.
> >
> > Mattias
> >
> > _________________________________________________________________
> > To unsubscribe: mail lazarus-request at miraclec.com with
> > "unsubscribe" as the Subject
> > archives at http://www.lazarus.freepascal.org/mailarchives
More information about the Lazarus
mailing list