[Lazarus] Attn Mattias: is r45063 correct? Fixed building lhelp under FPC 2.6.4
Mattias Gaertner
nc-gaertnma at netcologne.de
Mon May 19 10:34:43 CEST 2014
On Mon, 19 May 2014 10:21:44 +0200
Reinier Olislagers <reinierolislagers at gmail.com> wrote:
> Saw this
> r45063
> lhelp: fixed building lhelp under fpc 2.6.4
>
> ---
> branches/fixes_1_2/components/chmhelp/packages/idehelp/lazchmhelp.pas
> 2014/05/17 18:55:25 45062
> +++
> branches/fixes_1_2/components/chmhelp/packages/idehelp/lazchmhelp.pas
> 2014/05/17 18:57:08 45063
> @@ -283,6 +283,9 @@
> // Exit;
>
> Proc := TProcessUTF8.Create(nil);
> + {$if FPC_FULLVERSION<20400}
> + Proc.InheritHandles := false;
> + {$endif}
> {$if (fpc_version=2) and (fpc_release<5)}
> Proc.CommandLine := Lazbuild+' '+WS+' '+PCP+' '+LHelpProject;
> {$else}
>
> However, that tests for FPC up to and including FPC 2.3, not 2.6.4 and up
> Either:
> 1. the description of the fix is wrong
> 2. the fix is wrong
> 3. I haven't had enough coffee or there's something else wrong with me...
You are right. It should be 20604. Fixed.
Mattias
More information about the Lazarus
mailing list