[Lazarus] CHM help package

[Sergey Bodrov]

2017-12-13 12:09 GMT+03:00 Werner Pamler via Lazarus <
lazarus at lists.lazarus-ide.org>:

> Am 13.12.2017 um 08:35 schrieb Sergey Bodrov via Lazarus:
>
>> I personally greteful, that you helps me. But I don't understand whole
>> situation with code formatting, it looks like a some 'social bug' for me.
>> If code formatting of existing code is prohibited, then must be some public
>> warning in wiki.
>>
>
> Looks like you really don't understand. I won't repeat what has been said
> before. Just one question: If you were the reviewer who added this patch to
> fcl and suddenly somebody finds out that this patch creates a crash
> somewhere else, how can you find the faulty line if there are thousands of
> irrelevant changes but 1 tiny incorrect "shr 1" somewhere?
>

I can't make review from single line of code or single function, that I
don't know, how it works and how connected to another parts. If it obvious
error, like missed inherited destructor, or known point of exception - then
it easy. But when it some hidden bug, wrong behavior - then need some code
preparing, that make wrong parts of code obvious or force some visible
effect in runtime. Comments, naming, debug output, assertions. And only
when code is perfectly looks and works, then it can be cleaned from
redundant parts and treated as some blackbox.

I thinked, that sources of FPC compiler and RTL is that 'holy bible', where
every line is critical and must be carefully checked. But CHM package is
optional and not documented, it have many unused and debug lines. I even
don't sure, that it actually part of FCL.


> If you really want code to be reformatted you must provide a separate
> patch which does not change anything in the logics of the code.


It make a sense. But how to bring a patch with only code formatting? It
must be single huge diff, or splitted for different blocks? And why file
with massive changes can't be treated as new file?


-- 
*Bodrov Sergey*
software development, IT consulting
http://www.serbod.com
*Phone (Belarus):* +375(25)794-21-58
*Skype:* sergey.bodrov1
*e-mail:* serbod at gmail.com, oxotnuk at yandex.ru
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.lazarus-ide.org/pipermail/lazarus/attachments/20171213/be991b10/attachment.html>