[Qt] QT patch

[Jesus Reyes]

--- Felipe Monteiro de Carvalho <felipemonteiro.carvalho at gmail.com>
escribió:

> On 1/7/07, Jesus Reyes <jesusrmx at yahoo.com.mx> wrote:
> > Also the patch is large, many things were changed. I think first
> it
> > should be approved in general, I don't see the point in
> continuing to
> > add features if current structure and methods are not likely to
> match
> > everybody's idea of qt interface improving.
> 
> umm ... the problem is that the patch is too large, and cannot be
> separated. I tryed to separate the qt4.pas part, but it can´t be
> compiled without it.

you are right. I will try to comment on the patch in a separated
message.

I was using 1.24 and now 1.26, for 1.26 just a little change is
necessary, because QVariant_create(cardinal) has disappeared however
QVariant_toUInt() is still there, in the new patch I', using
QVariant_create(int64) probably also QVariant_create(integer) could
be used, but after that it 4.2.2 with 1.26 seems working right. Will
update the shortly.

> 
> About the general idea of the patch, I agree with it, but I also
> think
> it needs a little more work. Specifically:
> 
> * Can you investigate substituting TQtDCData with qpainter_save and
> qpainter_restore?

Currently qpainter_save and qpainter_restore is used, the code using
TQtDCData is commented, I think it could be elimintaded without
problems. If necesary it could be added later.

> 
> That would take a lot of code from the patch.
> 


> * It would be nice if rotated text works again. Regressions aren´t
> good.
>

:) I don't like regressions also, but as I said in other message, it
could be great if test cases are provided and if we have some of them
before commiting the patch it would be even best.


Btw I found other problem in TQtMainWindow.SetTabOrders, if there is
only one control in a groupbox for example, after tabbing with
keyword application freeze, I will include a fix in the next patch.
 
> thanks,
> -- 
> Felipe Monteiro de Carvalho

Jesus Reyes A.


__________________________________________________
Correo Yahoo!
Espacio para todos tus mensajes, antivirus y antispam ¡gratis! 
Regístrate ya - http://correo.yahoo.com.mx/